mrcjkb commented on code in PR #3010:
URL: https://github.com/apache/thrift/pull/3010#discussion_r1698059092
##########
lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java:
##########
@@ -302,6 +302,14 @@ public FrameBuffer(
}
}
+ /**
+ * Sets the selection key.
+ * @param selectionKey the new key to set.
+ */
+ public void setSelectionKey(SelectionKey selectionKey) {
Review Comment:
My concern is that both `FrameBuffer` and `setSelectionKey` are public, so
this could be a footgun in the future.
But based on your comment, I'd say YAGNI for now. I've added a note that
it's not tread safe to the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
