OneSizeFitsQuorum commented on code in PR #3010:
URL: https://github.com/apache/thrift/pull/3010#discussion_r1697785441
##########
lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java:
##########
@@ -626,17 +626,23 @@ private synchronized void rebuildSelector() {
LOGGER.error("Create new Selector error.", e);
}
- for (SelectionKey key : oldSelector.selectedKeys()) {
- if (!key.isValid() && key.readyOps() == 0) continue;
+ for (SelectionKey key : oldSelector.keys()) {
+ if (!key.isValid() || key.channel().keyFor(newSelector) != null)
continue;
Review Comment:
if (!key.isValid() || key.interestOps() == 0 ||
key.channel().keyFor(newSelector) != null)
##########
lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java:
##########
@@ -626,17 +626,23 @@ private synchronized void rebuildSelector() {
LOGGER.error("Create new Selector error.", e);
}
- for (SelectionKey key : oldSelector.selectedKeys()) {
- if (!key.isValid() && key.readyOps() == 0) continue;
+ for (SelectionKey key : oldSelector.keys()) {
+ if (!key.isValid() || key.channel().keyFor(newSelector) != null)
continue;
SelectableChannel channel = key.channel();
Object attachment = key.attachment();
+ int interestOps = key.interestOps();
+ SelectionKey newKey;
try {
if (attachment == null) {
- channel.register(newSelector, key.readyOps());
+ newKey = channel.register(newSelector, interestOpts);
} else {
- channel.register(newSelector, key.readyOps(), attachment);
+ newKey = channel.register(newSelector, interestOpts, attachment);
}
+ if (attachment instanceof FrameBuffer) {
+ ((FrameBuffer) attachment.setSelectionKey(newKey);
+ }
+ key.cancel();
Review Comment:
Seems redundant as we will call oldSelector.close() later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
