SvenRoederer commented on PR #2999:
URL: https://github.com/apache/thrift/pull/2999#issuecomment-2242751300
I'm aware of the principle of code-changes for open projects. There is a
change-idea, that gets written down and discussed by project members.
I wrote my change-idea ("use existing test-cases for more language-levels,
instead of adding another test-file") as code, that looked working to me and
proposed up for discussion. As I had the code changes ready it was easy for me
to publish them via this PR and to have something to look at, that just
discussing on a pure idea of how to change things. If the change does not fit
the projects intention, then it is this way ...
> I'd propose to compare the generated code for each option and/or looking
at the code generator.
From this comment I see, that it's not surprising that the
"Test_Complex_DeepCopy" will fail when not using net8. As @Jens-G is more deep
in the project and code, I'm fine with this and consider this seen test-fail as
"Works as designed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
