SvenRoederer commented on PR #2999:
URL: https://github.com/apache/thrift/pull/2999#issuecomment-2231355179
When using these changes it turns out that the netstd-test failing after
removing the "net8" option from calling the compiler
I can see this when runnig localy and a also in GithubActions (using #2998)
~~~
Test run for
/home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/bin/Debug/net8.0/Thrift.Tests.dll
(.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.10.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Failed Test_Complex_DeepCopy [16 ms]
Error Message:
Assert.IsNotNull failed.
Stack Trace:
at Thrift.Tests.DataModel.DeepCopyTests.InitializeInstance(RaceDetails
instance, Int32 nesting) in
/home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/DataModel/DeepCopy.cs:line
[90](https://github.com/SvenRoederer/thrift/actions/runs/9959985460/job/27518257532#step:10:91)
at Thrift.Tests.DataModel.DeepCopyTests.Test_Complex_DeepCopy() in
/home/runner/work/thrift/thrift/lib/netstd/Tests/Thrift.Tests/DataModel/DeepCopy.cs:line
36
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void**
arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj,
BindingFlags invokeAttr)
Failed! - Failed: 1, Passed: 30, Skipped: 0, Total: 31,
Duration: 113 ms - Thrift.Tests.dll (net8.0)
~~~
I'm not that deep in C# and test-code at all, to debug this/fix. Maybe this
fail should become a new Issue (to be treated by anyone with the power/access
to Jira).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
