salomon-smekecohen commented on code in PR #2929:
URL: https://github.com/apache/thrift/pull/2929#discussion_r1599036424
##########
compiler/cpp/src/thrift/generate/t_py_generator.cc:
##########
@@ -2908,4 +3021,5 @@ THRIFT_REGISTER_GENERATOR(
" Package prefix for generated files.\n"
" old_style: Deprecated. Generate old-style classes.\n"
" enum: Generates Python's IntEnum, connects thrift to
python enums. Python 3.4 and higher.\n"
+ " type_hints: Generate type hints in write method, including
IntEnum generation.\n"
Review Comment:
I would consider re-wording this slightly.
```
Generate type hints in write method, requires and enables Enum generation.
```
IntEnum generated files are not backwards compatible with users that
leverage the key_to_value mappings to perform conversions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
