Jens-G commented on code in PR #2929:
URL: https://github.com/apache/thrift/pull/2929#discussion_r1588806699
##########
test/py/Makefile.am:
##########
@@ -117,6 +121,12 @@ gen-py-enum/%/__init__.py: ../%.thrift $(THRIFT)
&& $(THRIFT) --gen py:enum -out gen-py-enum ../v0.16/$(notdir $<) \
|| $(THRIFT) --gen py:enum -out gen-py-enum $<
+gen-py-type_hints/%/__init__.py: ../%.thrift $(THRIFT)
+ test -d gen-py-type_hints || $(MKDIR_P) gen-py-type_hints
+ test ../v0.16/$(notdir $<) \
+ && $(THRIFT) --gen py:type_hints -out gen-py-type_hints
../v0.16/$(notdir $<) \
Review Comment:
+1 LGTM just one question: UUIDs are handled (at least from what i see
above) but you still want to test against the old uuid-free v0.16 version of
IDL files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
