PG1204 commented on PR #5146: URL: https://github.com/apache/texera/pull/5146#issuecomment-4608000190
> > > you can > > > > > > * move out workflow-editor.component.spec.ts from exclusion list, > > > * add your new tests there while keeping other tests still commented. > > > > > > Alternatively you can use another PR to enable this workflow-editor.component.spec.ts and uncomment and fix the previous test cases first. > > > > > > @Xiao-zhen-Liu Quick question on the follow-up PR before I start on it, the 6 currently-commented-out mouse-event tests in workflow-editor.component.spec.ts fail under jsdom but pass under the new test-browser target. Given that main now has the *.browser.spec.ts convention (jsdom skips them, real Chrome runs them), my plan for the follow-up is to: > > Move the 6 mouse-event tests into a new sibling file workflow-editor.browser.spec.ts (uncommented), with its own TestBed setup. Remove the commented-out blocks and the orphan imports they leave behind from workflow-editor.component.spec.ts. No angular.json changes, the new file is picked up by test-browser and skipped by test automatically thanks to the .browser.spec.ts glob. Does that approach sound right, or would you prefer something different (e.g. polyfilling the jsdom gaps to keep everything in one file, or some other split)? > > Can you move this discussion as a new issue if it is not going to be part of this PR? Sure, will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
