Xiao-zhen-Liu commented on code in PR #5146:
URL: https://github.com/apache/texera/pull/5146#discussion_r3320350398
##########
frontend/angular.json:
##########
@@ -92,10 +92,7 @@
"runnerConfig": "vitest.config.ts",
"tsConfig": "src/tsconfig.spec.json",
"include": ["**/*.spec.ts"],
- "setupFiles": ["src/jsdom-svg-polyfill.ts"],
- "exclude": [
-
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts"
- ]
+ "setupFiles": ["src/jsdom-svg-polyfill.ts"]
Review Comment:
Decomposability: un-excluding this spec from the default jsdom target is a
CI/test-infra change that is logically independent of the operator-border bug
fix. Bundling them couples a behavior fix to a test-config change, making the
PR harder to review and revert as a unit. Consider splitting the
test-enablement into its own PR.
Also note `test-browser` (line 105 below) includes *only* this spec — see
the comment on the commented-out tests in the spec file for why that matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
