Ma77Ball commented on code in PR #5300:
URL: https://github.com/apache/texera/pull/5300#discussion_r3331183051
##########
amber/src/main/scala/org/apache/texera/web/service/WorkflowService.scala:
##########
@@ -204,7 +204,7 @@ class WorkflowService(
workflowContext.executionId =
ExecutionsMetadataPersistService.insertNewExecution(
workflowContext.workflowId,
- uidOpt,
+ uidOpt.orNull,
Review Comment:
Good call. The call site now fails early: I derive `val uid =
uidOpt.getOrElse(throw new IllegalArgumentException(...))` before calling
`insertNewExecution`, so a `None` uid raises immediately with a clear message
instead of passing `orNull` and letting the DB reject the insert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
