bito-code-review[bot] commented on code in PR #38119:
URL: https://github.com/apache/superset/pull/38119#discussion_r2832392101
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -49,6 +49,32 @@ export const TIMESERIES_CONSTANTS = {
horizontalBarLabelRightPadding: 70,
};
+export const LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
+ [LabelPositionEnum.InsideLeft, 'Inside left'],
+ [LabelPositionEnum.InsideRight, 'Inside right'],
+ [LabelPositionEnum.InsideTop, 'Inside top'],
+ [LabelPositionEnum.InsideBottom, 'Inside bottom'],
+ [LabelPositionEnum.InsideTopLeft, 'Inside top left'],
+ [LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
+ [LabelPositionEnum.InsideTopRight, 'Inside top right'],
+ [LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
+];
+
+// Radar charts use polar coordinates and only support a limited set of label
positions
+// These are the positions that ECharts correctly renders for radar series
data items
+export const RADAR_LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing translation for UI labels</b></div>
<div id="fix">
The display labels in RADAR_LABEL_POSITION are hardcoded strings, but per
codebase guidelines, all user-facing text should be wrapped with the
translation function t() to support internationalization. Other similar
constants in this file already follow this pattern.
</div>
</div>
<small><i>Code Review Run #9c3cb3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
