Vansh5632 opened a new pull request, #38119: URL: https://github.com/apache/superset/pull/38119
### SUMMARY The Radar chart's **Label Position** dropdown offered 13 options (e.g. `Inside Left`, `Inside Bottom Right`) copied from the shared `LABEL_POSITION` constant designed for Cartesian charts. Radar charts use a **polar coordinate system**, so ECharts silently ignores unsupported positions and always falls back to `top`, making these options non-functional. This PR introduces a new `RADAR_LABEL_POSITION` constant restricted to the 5 positions that ECharts correctly renders for radar series: - Top - Left - Right - Bottom - Inside The Radar control panel now uses this constant instead of the full shared `LABEL_POSITION` list. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** Selecting any label position other than `Top` had no effect — labels always appeared above the data points. **After:** Selecting `Left`, `Right`, `Bottom`, or `Inside` correctly repositions the data labels on the radar chart. ### TESTING INSTRUCTIONS 1. Open Superset and create a Radar chart with at least one metric and a group-by column. 2. Enable **Show Labels** under the Labels section. 3. Open the **Label Position** dropdown — you should see only 5 options: Top, Left, Right, Bottom, Inside. 4. Select each option and verify that labels visually move to the expected position. To run unit tests: ```bash cd superset-frontend npm run test -- plugins/plugin-chart-echarts/test/Radar/transformProps.test.ts ``` All 10 tests should pass (4 pre-existing + 6 new label-position tests). ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #37449 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
