msyavuz commented on code in PR #34935:
URL: https://github.com/apache/superset/pull/34935#discussion_r2329799306
##########
superset-frontend/src/features/home/Menu.tsx:
##########
@@ -285,7 +286,7 @@ export function Menu({
>
<Image
preview={false}
- src={theme.brandLogoUrl}
+ src={assetUrl(theme.brandLogoUrl)}
Review Comment:
> Maybe assetUrl() could also check the value passed to it is a relative
path and only add the prefix then?
Yes, that would be my solution as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
