martyngigg commented on code in PR #34935:
URL: https://github.com/apache/superset/pull/34935#discussion_r2330462397


##########
superset-frontend/src/features/home/Menu.tsx:
##########
@@ -285,7 +286,7 @@ export function Menu({
         >
           <Image
             preview={false}
-            src={theme.brandLogoUrl}
+            src={assetUrl(theme.brandLogoUrl)}

Review Comment:
   I've gone with adding a second `assetUrlf` that checks for the relative path 
as in the other places it is used the check is not necessary so it avoids 
wasting time in those places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to