bito-code-review[bot] commented on code in PR #35001:
URL: https://github.com/apache/superset/pull/35001#discussion_r2319738079
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -286,14 +288,16 @@ const StyledDashboardContent = styled.div<{
padding-left: 0;
}
+ .grid-container .ant-tabs-nav {
+ padding-left: 0 !important;
+ }
+
.grid-container {
/* without this, the grid will not get smaller upon toggling the builder
panel on */
width: 0;
flex: 1;
position: relative;
- margin-top: ${theme.sizeUnit * 4}px;
- margin-right: ${theme.sizeUnit * 8}px;
- margin-bottom: ${theme.sizeUnit * 4}px;
+ margin: ${theme.sizeUnit * 4}px;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CSS margin property change breaks layout</b></div>
<div id="fix">
CSS property order issue: The shorthand `margin` property sets all margins
including `margin-left`, but the specific `margin-left: ${marginLeft}px` on
line 301 should override it. However, the current implementation may cause
inconsistent margin behavior. The shorthand margin property changes the right
margin from `${theme.sizeUnit * 8}px` to `${theme.sizeUnit * 4}px`, which could
break the dashboard layout spacing.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
margin: ${theme.sizeUnit * 4}px ${theme.sizeUnit * 8}px
${theme.sizeUnit * 4}px 0;
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35001#issuecomment-3250166864>#88102f</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
