gabotorresruiz opened a new pull request, #35001: URL: https://github.com/apache/superset/pull/35001
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Normalized dashboard layout spacings and improved background colors consistency. Key changes include: - **Simplified margin logic**: Changed dashboard content margin calculation from complex conditional logic to a simpler editMode-based approach - **Consistent background colors**: Added proper background colors (`colorBgContainer` for filters panel, `colorBgLayout` for main content) - **Fixed tab navigation padding**: Made tab navigation padding responsive to dashboard filter state - **Unified grid container margins**: Simplified grid container margins from separate top/right/bottom/left values to a unified margin approach ### BEFORE/AFTER SCREENSHOTS <!--- Skip this if not applicable --> Before: <img width="1512" height="824" alt="Screenshot 2025-09-03 at 13 29 22" src="https://github.com/user-attachments/assets/bebb2a2a-1736-486a-9c7c-161cb501d69e"; /> <img width="1512" height="735" alt="Screenshot 2025-09-03 at 13 28 35" src="https://github.com/user-attachments/assets/59466b73-71fa-4c2f-b1a8-b55ce2dee07f"; /> After: <img width="1512" height="824" alt="Screenshot 2025-09-03 at 14 01 35" src="https://github.com/user-attachments/assets/7e1b5a8c-aa40-4742-9773-c4228bc4d8f6"; /> <img width="1512" height="673" alt="Screenshot 2025-09-03 at 13 21 56" src="https://github.com/user-attachments/assets/b30ae192-d467-4764-86d1-cfa60bb2037e"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Open any dashboard in Superset 2. Verify consistent background colors across the dashboard interface 3. Toggle between edit mode and view mode - observe proper spacing adjustments 4. Open/close the native filters panel - verify tab navigation padding adjusts correctly 5. Test with different filter bar orientations (horizontal/vertical) 6. Ensure no visual regressions in grid layout and component spacing ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
