betodealmeida commented on code in PR #34296:
URL: https://github.com/apache/superset/pull/34296#discussion_r2240179337
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/customControls.tsx:
##########
@@ -41,6 +41,53 @@ import {
import { checkColumnType } from '../utils/checkColumnType';
import { isSortable } from '../utils/isSortable';
+// Aggregation choices with computation methods for plugins and controls
+export const aggregationChoices = {
+ raw: {
+ label: 'Force server-side aggregation',
Review Comment:
I would strongly prefer something else here, since the user shouldn't care
if the aggregation is done on the server or on the client. In fact, one might
argue that if the chart is slow a user might want to choose this "to make
things faster since it forces the aggregation to run on the server".
A few suggestions:
- "Overall" or "overall value"
- "Whole time period"
- "Whole series"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
