betodealmeida commented on code in PR #34296:
URL: https://github.com/apache/superset/pull/34296#discussion_r2232010776
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/customControls.tsx:
##########
@@ -41,6 +41,53 @@ import {
import { checkColumnType } from '../utils/checkColumnType';
import { isSortable } from '../utils/isSortable';
+// Aggregation choices with computation methods for plugins and controls
+export const aggregationChoices = {
+ raw: {
+ label: 'Force server-side aggregation',
Review Comment:
I'm not sure if this is clearer to the user... "server-side" is an
implementation detail.
My understanding is that when this option is selected we ignore the time
grain when computing the big number. If the grain is monthly, and the metric is
`AVG(price)`, we would have:
- The "trendline" (which is not a trendline) would show a timeseries of
`AVG(price)` per month.
- The big number would show the overall `AVG(price)`, from start to end of
the data.
So I think renaming this to "Overall value" would make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
