mistercrunch commented on PR #33601: URL: https://github.com/apache/superset/pull/33601#issuecomment-2941960910
Two options: abuse the semantic meaning of the tokens and use things like `colorErrorBorderHover` (for light) and `colorErrorText` for dark. Or we use a RGB library/function and constant (say +10%, -10%) to lighten/darken the base color (`colorError`). The second option seems more right and you can use `tinycolor2`. Knowing there's a regression in the branch and that it's a bit much for the person handling the eventual merge conflict, I'd recommend taking on the change on that branch and getting things right there using `tinycolor2` to apply the right transformation. Ideally we apply the same/right amount to darken/lighten in a way that roughly matches the color we happen to have now. @EmmanuelCbd are you willing to take this on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
