mistercrunch commented on PR #33601: URL: https://github.com/apache/superset/pull/33601#issuecomment-2941940538
This will merge conflict with the theming branch, wondering if you should use/target that branch instead. Here's what it looks like in the new branch (to be merged soon) -> https://github.com/apache/superset/blob/template_less/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx#L53-L57 Note sure why we're missing the dark tones in that branch, maybe a bad merge conflict resolve from a previous PR? Seems like a regression... Glad to catch it before it hits. Anyhow we should think about what it'll look like in that branch, should probably find matching color using the antd-v5 tokens. Here's the before/after on the tokens now that we use "semantic shades": <img width="1379" alt="Screenshot 2025-06-04 at 4 27 08 PM" src="https://github.com/user-attachments/assets/01165861-c7a8-40ae-ab58-7c5191922e38"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
