Re: [PR] fix: Clicking in the body of a Markdown component does not put it into edit mode [superset]

Mon, 24 Mar 2025 13:56:25 -0700 


korbit-ai[bot] commented on code in PR #32384:
URL: https://github.com/apache/superset/pull/32384#discussion_r2010884626


##########
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx:
##########
@@ -295,15 +295,17 @@ class Markdown extends PureComponent {
     const { hasError } = this.state;
 
     return (
-      <SafeMarkdown
-        source={
-          hasError
+      <div className="menu-item">

Review Comment:
   ### Misleading wrapper class name affecting functionality <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The 'menu-item' class name used for the wrapping div may conflict with 
existing menu styling and doesn't semantically represent the purpose of this 
wrapper.
   
   ###### Why this matters
   Using a class name meant for menu items could accidentally inherit 
unintended styles and behavior from other menu components, potentially 
interfering with the click-to-edit functionality.
   
   ###### Suggested change ∙ *Feature Preview*
   Change the class name to something more specific and semantically meaningful:
   ```jsx
   <div className="markdown-content-wrapper">
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/2de53e60-dc17-410b-bd1b-52d755a606df/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/2de53e60-dc17-410b-bd1b-52d755a606df?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/2de53e60-dc17-410b-bd1b-52d755a606df?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/2de53e60-dc17-410b-bd1b-52d755a606df?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/2de53e60-dc17-410b-bd1b-52d755a606df)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:f4b410bb-91d0-41f9-86cf-89b4f8c60ce7 -->
   
   [](f4b410bb-91d0-41f9-86cf-89b4f8c60ce7)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to