Re: [PR] fix: Clicking in the body of a Markdown component does not put it into edit mode [superset]

Mon, 24 Mar 2025 13:37:58 -0700 


korbit-ai[bot] commented on code in PR #32384:
URL: https://github.com/apache/superset/pull/32384#discussion_r2010891363


##########
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx:
##########
@@ -295,15 +295,15 @@ class Markdown extends PureComponent {
     const { hasError } = this.state;
 
     return (
-      <SafeMarkdown
-        source={
-          hasError
+        <SafeMarkdown
+          source={
+            hasError
             ? MARKDOWN_ERROR_MESSAGE
             : this.state.markdownSource || MARKDOWN_PLACE_HOLDER
         }
         htmlSanitization={this.props.htmlSanitization}
-        htmlSchemaOverrides={this.props.htmlSchemaOverrides}
-      />
+          htmlSchemaOverrides={this.props.htmlSchemaOverrides}
+        />

Review Comment:
   ### Inconsistent JSX Prop Indentation <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Inconsistent indentation in JSX elements makes the code structure harder to 
follow. Some props are indented with 8 spaces while others use 10 spaces.
   
   ###### Why this matters
   Inconsistent indentation can make it difficult to visually track the 
component hierarchy and prop relationships, increasing cognitive load when 
reading the code.
   
   ###### Suggested change ∙ *Feature Preview*
   ```jsx
           <SafeMarkdown
             source={
               hasError
                 ? MARKDOWN_ERROR_MESSAGE
                 : this.state.markdownSource || MARKDOWN_PLACE_HOLDER
             }
             htmlSanitization={this.props.htmlSanitization}
             htmlSchemaOverrides={this.props.htmlSchemaOverrides}
           />
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/56472037-9bae-488e-9282-90932ae456a8/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/56472037-9bae-488e-9282-90932ae456a8?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/56472037-9bae-488e-9282-90932ae456a8?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/56472037-9bae-488e-9282-90932ae456a8?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/56472037-9bae-488e-9282-90932ae456a8)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:41451ff6-3945-4b2b-a0ec-4099456c174e -->
   
   [](41451ff6-3945-4b2b-a0ec-4099456c174e)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to