korbit-ai[bot] commented on code in PR #32410:
URL: https://github.com/apache/superset/pull/32410#discussion_r1973599933
##########
superset/commands/importers/v1/__init__.py:
##########
@@ -104,6 +107,8 @@ def validate(self) -> None: # noqa: F811
self._prevent_overwrite_existing_model(exceptions)
if exceptions:
+ for ex in exceptions:
+ logger.warning("Import Error: %s",ex)
Review Comment:
### Incorrect log level for critical errors <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Using warning level for import validation errors that lead to command failure
###### Why this matters
Warning level suggests the error is not severe, but these validation errors
cause command failure and should be treated as errors
###### Suggested change ∙ *Feature Preview*
Use error level logging instead:
```python
logger.error("Import validation error: %s", ex)
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a836a3de-1efd-48b1-a03a-f73e46e0d256?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:c3d1c140-5af6-47f2-afd2-d8d7d43204d2 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
