hainenber commented on code in PR #32410:
URL: https://github.com/apache/superset/pull/32410#discussion_r1975362462
##########
superset/commands/importers/v1/__init__.py:
##########
@@ -104,6 +107,8 @@ def validate(self) -> None: # noqa: F811
self._prevent_overwrite_existing_model(exceptions)
if exceptions:
+ for ex in exceptions:
+ logger.warning("Import Error: %s", ex)
raise CommandInvalidError(
Review Comment:
L112 already raised the exceptions and surely logged by the logger. You're
not seeing the exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
