Re: [PR] refactor(Icons): Replaces custom icons with Ant Design 5 icons [superset]

Thu, 27 Feb 2025 02:30:41 -0800 


kgabryje commented on PR #32112:
URL: https://github.com/apache/superset/pull/32112#issuecomment-2687534009

   > Here as well: BEFORE: 
![image](https://private-user-images.githubusercontent.com/37236580/417529400-f41ebb00-5c0b-46c1-a98a-797da51beb3d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA2NTI0MTUsIm5iZiI6MTc0MDY1MjExNSwicGF0aCI6Ii8zNzIzNjU4MC80MTc1Mjk0MDAtZjQxZWJiMDAtNWMwYi00NmMxLWE5OGEtNzk3ZGE1MWJlYjNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjI3VDEwMjgzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3ZmVlNTYwYTQzZDYwZWNmYjk5MzEyNWRlNjY0YzIzMjNjNzdhMGFhMGVhMGM5ZTBkMDc3NmNiNWI2MjM3MGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QtUktr-G8W0zlzFh1ULECbch3Jb6VtHY24K53U-ysK8)
 AFTER: 
![image](https://private-user-images.githubusercontent.com/37236580/417529561-750e2efb-3607-4ebb-8652-9cd56f967135.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXR
 
odWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA2NTI0MTUsIm5iZiI6MTc0MDY1MjExNSwicGF0aCI6Ii8zNzIzNjU4MC80MTc1Mjk1NjEtNzUwZTJlZmItMzYwNy00ZWJiLTg2NTItOWNkNTZmOTY3MTM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjI3VDEwMjgzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyMmMxOWZiN2IyNmZiYWZhZTVlMmU1ZTY1MWUzNjljYzg2ZDM3M2QwNDA1NTBhOTE2OTIwZWRlZmM2YmJkMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FWL0oxKw_UPWZVwXzzDqN1AvtNwb8tDuNifOXOIj-ao)
   
   It also looks like the icons are not centered in the new version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to