alexandrusoare commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1973191619
##########
superset-frontend/src/components/Icons/Icon.tsx:
##########
@@ -73,8 +101,8 @@ export const Icon = (props: IconProps) => {
}, [fileName, ImportedSVG]);
const whatRole = props?.onClick ? 'button' : 'img';
-
return (
+ // @ts-ignore to be removed
<StyledIcon
Review Comment:
Just a small nit, but in storybook the order of the sizes is ['s', 'l', 'm',
'xl', 'xxl'] and it should be ['s', 'm', 'l', 'xl', 'xxl']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
