mistercrunch commented on code in PR #32017:
URL: https://github.com/apache/superset/pull/32017#discussion_r1933149737
##########
Dockerfile:
##########
@@ -100,21 +99,14 @@ RUN if [ "$BUILD_TRANSLATIONS" = "true" ]; then \
# Base python layer
######################################################################
FROM python:${PY_VER} AS python-base
-ARG BUILD_TRANSLATIONS="false" # Include translations in the final build
-ENV BUILD_TRANSLATIONS=${BUILD_TRANSLATIONS}
-ARG DEV_MODE="false" # Skip frontend build in dev mode
-ENV DEV_MODE=${DEV_MODE}
-
-ENV LANG=C.UTF-8 \
Review Comment:
LANG/ LC_ALL are not needed anymore as of 3.9 I believe. Other ENVs we don't
need in this layer. Turns out ENV don't carry through a layer with a different
base and led to some confusion on my part. As it was ENV would not carry
through to the final layers, but they do when located in python-common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
