mistercrunch commented on code in PR #32017: URL: https://github.com/apache/superset/pull/32017#discussion_r1933148120
########## Dockerfile: ########## @@ -76,8 +76,7 @@ COPY superset-frontend /app/superset-frontend FROM superset-node-ci AS superset-node # Build the frontend if not in dev mode -RUN --mount=type=cache,target=/app/superset-frontend/.temp_cache \ - --mount=type=cache,target=/root/.npm \ +RUN --mount=type=cache,target=$/root/.npm \ Review Comment: Here caching the cache mount was preventing the docker-compose-level mount from hooking up the cache to the host. Getting a nice perf boost by letting the host mount do what it's supposed to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
