hainenber commented on code in PR #31979:
URL: https://github.com/apache/superset/pull/31979#discussion_r1932423690
##########
superset-frontend/src/dashboard/components/SyncDashboardState/index.tsx:
##########
@@ -66,10 +67,13 @@ const selectDashboardContextForExplore = createSelector(
(state: RootState) => state.dataMask,
],
(metadata, dashboardId, colorScheme, filters, dataMask) => {
- const nativeFilters = Object.keys(filters).reduce((acc, key) => {
- acc[key] = pick(filters[key], ['chartsInScope']);
- return acc;
- }, {});
+ const nativeFilters = Object.keys(filters).reduce(
+ (acc, key) => {
+ acc[key] = pick(filters[key], ['chartsInScope']);
+ return acc;
+ },
+ {} as Record<string, Pick<Filter | Divider, 'chartsInScope'>>,
+ );
Review Comment:
@korbit-ai 72th line has this type for the assigned value: `Pick<Filter |
Divider, "chartsInScope">`. Removing `Filter` doesn't really make sense for the
inferred type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
