Airliquide76 commented on code in PR #29840:
URL: https://github.com/apache/superset/pull/29840#discussion_r1927589835
##########
superset/connectors/sqla/models.py:
##########
@@ -1963,7 +1965,7 @@ class and any keys added via `ExtraCache`.
if self.has_extra_cache_key_calls(query_obj):
sqla_query = self.get_sqla_query(**query_obj)
extra_cache_keys += sqla_query.extra_cache_keys
- return extra_cache_keys
+ return list(set(extra_cache_keys))
Review Comment:
in our case it break the chart key retreiving !
we've got some logs saying cache retreiving failed !
Query works on sql-lab but crash in chart or dashboard ( works if force
refresh as it does not go to cache )
We are using a lot of url_params reading at the dataset execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
