ERGO1995 commented on code in PR #29840:
URL: https://github.com/apache/superset/pull/29840#discussion_r1927373983
##########
superset/connectors/sqla/models.py:
##########
@@ -1963,7 +1965,7 @@ class and any keys added via `ExtraCache`.
if self.has_extra_cache_key_calls(query_obj):
sqla_query = self.get_sqla_query(**query_obj)
extra_cache_keys += sqla_query.extra_cache_keys
- return extra_cache_keys
+ return list(set(extra_cache_keys))
Review Comment:
Why we replace this line? Actually not doing great job in our case related
to https://github.com/apache/superset/issues/31975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
