michael-s-molina commented on code in PR #31794:
URL: https://github.com/apache/superset/pull/31794#discussion_r1914675646
##########
superset-frontend/src/dashboard/components/nativeFilters/utils.test.ts:
##########
@@ -45,6 +45,12 @@ describe('nativeFilterGate', () => {
});
it('should return false for native filter chart with cross filter
support', () => {
+ isFeatureEnabledMock.mockImplementation(feature => {
+ if (feature === FeatureFlag.DASHBOARD_CROSS_FILTERS) return false;
Review Comment:
I believe `FeatureFlag.DASHBOARD_CROSS_FILTERS` will not exist anymore given
that we are removing the feature flag. We need to remove all references of it.
##########
UPDATING.md:
##########
@@ -23,6 +23,7 @@ This file documents any backwards-incompatible changes in
Superset and
assists people when migrating to a new version.
## Next
+- [31794](https://github.com/apache/superset/pull/31794) Removed the
previously deprecated `DASHBOARD_CROSS_FILTERS` feature flag
Review Comment:
```suggestion
- [31794](https://github.com/apache/superset/pull/31794) Removed the
previously deprecated `DASHBOARD_CROSS_FILTERS` feature flag.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
