rusackas commented on code in PR #31794:
URL: https://github.com/apache/superset/pull/31794#discussion_r1913897842
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -475,8 +472,7 @@ const DashboardBuilder = () => {
ELEMENT_ON_SCREEN_OPTIONS,
);
- const showFilterBar =
- (crossFiltersEnabled || nativeFiltersEnabled) && !editMode;
Review Comment:
Not sure, actually, but it's part of an OR statement, so with
crossFiltersEnabled always being true, it doesn't actually matter, so the whole
parenthetical will be true, and then `showFilterBar` can be replaced by
`!editMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
