mistercrunch commented on code in PR #31747:
URL: https://github.com/apache/superset/pull/31747#discussion_r1909492579
##########
docker-compose-image-tag.yml:
##########
@@ -22,9 +22,6 @@
# unique random secure passwords and SECRET_KEY.
# -----------------------------------------------------------------------
x-superset-image: &superset-image
apachesuperset.docker.scarf.sh/apache/superset:${TAG:-latest-dev}
-x-superset-depends-on: &superset-depends-on
Review Comment:
As much as I like DRY code, I felt like in yaml it was mostly just an
indirection as there's not a lot that's repeated here. Personally prefer have
it spelled out inline as opposed to having to look up a thing that has a few
line and is repeated a few times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
