Antonio-RiveroMartnez commented on code in PR #31747:
URL: https://github.com/apache/superset/pull/31747#discussion_r1908536372
##########
docker-compose-image-tag.yml:
##########
@@ -22,9 +22,6 @@
# unique random secure passwords and SECRET_KEY.
# -----------------------------------------------------------------------
x-superset-image: &superset-image
apachesuperset.docker.scarf.sh/apache/superset:${TAG:-latest-dev}
-x-superset-depends-on: &superset-depends-on
Review Comment:
nit: We could keep the anchor and just update the values of it with the new
conditions you have and also create a new one for the `superset-init:
condition: service_completed_successfully` so we can then reuse and refer to
these
##########
superset/utils/encrypt.py:
##########
@@ -22,7 +22,12 @@
from flask_babel import lazy_gettext as _
from sqlalchemy import text, TypeDecorator
from sqlalchemy.engine import Connection, Dialect, Row
-from sqlalchemy_utils import EncryptedType
+from sqlalchemy_utils import EncryptedType as SqlaEncryptedType
+
+
+class EncryptedType(SqlaEncryptedType):
Review Comment:
Why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
