rusackas commented on code in PR #31582:
URL: https://github.com/apache/superset/pull/31582#discussion_r1907469384


##########
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##########
@@ -255,13 +243,16 @@ function saveExploreColorScheme(
   cy.wait('@chartUpdate');
 }
 
+// FIXME: Skipping some tests as ECharts are rendered using Canvas and we 
cannot inspect the elements

Review Comment:
   It feels like we _could_ optimize this test, too, and use example dashboards 
to do fewer round trips between Dashboard and Chart Editor (though, maybe 
optimization is secondary, and round trip testing is a worthy effort too 
¯\_(ツ)_/¯)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to