michael-s-molina opened a new pull request, #31582: URL: https://github.com/apache/superset/pull/31582
### SUMMARY As part of the 5.0 breaking window, this PR executes the following proposals: - [23 - Force legacy Area chart migration and delete NVD3 plugin](https://github.com/orgs/apache/projects/345/views/1#) - [42 - Migrate Line Chart (legacy) to ECharts Line Chart and remove code (was previously deprecated)](https://github.com/orgs/apache/projects/345/views/1#) - [54 - Migrate and remove the legacy Heatmap chart](https://github.com/orgs/apache/projects/345/views/1#) - [80 - Migrate and remove the NVD3 Bar Chart in favor of ECharts](https://github.com/orgs/apache/projects/345/views/1#) - [84 - Migrate and remove the legacy Sankey chart](https://github.com/orgs/apache/projects/345/views/1#) - [85 - Remove the unused Sankey Loop chart](https://github.com/orgs/apache/projects/345/views/1#) - [86 - Migrate and remove the legacy Histogram chart](https://github.com/orgs/apache/projects/345/views/1#) - [88 - Remove the Event Flow chart](https://github.com/orgs/apache/projects/345/views/1#) - [89 - Migrate and remove the legacy Nightingale chart](https://github.com/orgs/apache/projects/345/views/1#) I decided to do it all in a single PR to have a single migration for the charts. There's also many code blocks that were removed that touches multiple visualization types at the same time and it would be more complex to remove it in parts. Another important factor was the ability to execute the tests once, given that we need to check if the example charts are loaded correctly. In summary, the benefits outweigh the review complexity. TODO: - Add the migration - Remove rose plugin ### TESTING INSTRUCTIONS - Check the examples are loaded correctly - Check that the charts in your production environment are all migrated and loaded correctly ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
