ERGO1995 commented on PR #31565: URL: https://github.com/apache/superset/pull/31565#issuecomment-2565178341
@rusackas thank you for your feedback. Yes, I agree that it would be cleaner. I'll take care of it. As for the array, I followed the same approach as for the FAVICONS. I probably didn’t quite understand why they were in array form as well? Otherwise, for this new element, I saw a GitHub issue mentioning loader customization. This could serve as a basis in case we want to add keys like the positioning of the loader or other ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
