rusackas commented on code in PR #31565:
URL: https://github.com/apache/superset/pull/31565#discussion_r1894285370
##########
superset/config.py:
##########
@@ -109,6 +109,7 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+LOADERS = [{"src": "/static/assets/images/loading.gif"}]
Review Comment:
Perhaps this is a bit of a side mission for another PR, or it could be part
of this, but I notice we have the FAVICON and LOADERS up here. APP_ICON is
waaaaay down below, but maybe they should live together in the config?
LOADERS could also probably use a comment explaining what it is, for anyone
learning what they can config.
Is there a reason it's an array? Can you use more than one? If it's just a
single GIF, it should probably be more singular like APP_ICON. And to be crazy
pedantic, maybe it should just be "LOADER" rather than "LOADERS"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
