mistercrunch commented on PR #31315: URL: https://github.com/apache/superset/pull/31315#issuecomment-2523983568
Ok, so I removed the nasty `SIMULATE_SLOW_ANALYTICS_DATABASE` feature flag, and I'm thinking ideally we need to put in a significant a refactor around what I wrote before: --- One question is whether we scrap this PR and chain it behind a large refactor, call it "untangle and centralize all analytics database interaction in the superset/db_engine_spec/ package". Goal there would be to move all analytics database operations in one place. One issue is that database interactions are somewhat tangled with Superset-specific logic, things like interaction with the cache manager, updating progress/status in the Query table, ... I think the way we'd handle it is by passing objects like the cache_manager to db_engine_spec, and even things like callbacks if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
