mistercrunch commented on code in PR #31315:
URL: https://github.com/apache/superset/pull/31315#discussion_r1873697531
##########
superset/models/core.py:
##########
@@ -691,27 +731,30 @@ def _log_query(sql: str) -> None:
with self.get_raw_connection(catalog=catalog, schema=schema) as conn:
Review Comment:
Would be there refactor analytics DB access to got through a single focal
point. I'd say a the logic related to external data access in
core.models.Database and in sql_lab.py and elsewhere should be brought in
DbEngineSpec. Make a lot of of the logic private to that package and have the
rest of the codebase use higher level abstractions like get_df or get_data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
