villebro commented on code in PR #31294:
URL: https://github.com/apache/superset/pull/31294#discussion_r1872177092
##########
superset/daos/query.py:
##########
@@ -35,25 +35,6 @@
class QueryDAO(BaseDAO[Query]):
base_filter = QueryFilter
- @staticmethod
- def update_saved_query_exec_info(query_id: int) -> None:
- """
- Propagates query execution info back to saved query if applicable
-
- :param query_id: The query id
- :return:
- """
- query = db.session.query(Query).get(query_id)
- related_saved_queries = (
- db.session.query(SavedQuery)
- .filter(SavedQuery.database == query.database)
- .filter(SavedQuery.sql == query.sql)
Review Comment:
But it seems to be very explicit about updating many rows, so I can only
assume the intent here is to actually update many queries. Looking at #11391 it
does indeed appear to be the intent. But this is clearly a perf problem, so I
would do away with this feature, and just update the actual query that ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
