villebro commented on code in PR #31294:
URL: https://github.com/apache/superset/pull/31294#discussion_r1872087136
##########
superset/daos/query.py:
##########
@@ -35,25 +35,6 @@
class QueryDAO(BaseDAO[Query]):
base_filter = QueryFilter
- @staticmethod
- def update_saved_query_exec_info(query_id: int) -> None:
- """
- Propagates query execution info back to saved query if applicable
-
- :param query_id: The query id
- :return:
- """
- query = db.session.query(Query).get(query_id)
- related_saved_queries = (
- db.session.query(SavedQuery)
- .filter(SavedQuery.database == query.database)
- .filter(SavedQuery.sql == query.sql)
Review Comment:
I was super confused by these filters, too. Is the intent here to update all
entries where the same database + query combo are featured? Seems very strange
to want to do that..?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
