currenjin opened a new pull request, #13797:
URL: https://github.com/apache/skywalking/pull/13797

   ### Add unit tests for JDBCTraceQueryDAO SQL building
   
   Add tests to verify the SQL query construction in `JDBCTraceQueryDAO`, 
covering:
   - `queryByTraceId`: TABLE_COLUMN and trace_id conditions appear correctly
   - `queryBySegmentIdList`: segment_id uses IN clause (not OR)
   - `queryByTraceIdWithInstanceId`: both trace_id and service_instance_id IN 
clauses are properly enclosed with parentheses, with correct AND between them
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to