currenjin opened a new pull request, #13796:
URL: https://github.com/apache/skywalking/pull/13796

   ### Add unit tests for JDBCLogQueryDAO SQL building
   
   Add tests to verify the SQL query construction in 
`JDBCLogQueryDAO.buildSQL()`, covering:
   - TABLE_COLUMN condition appears exactly once (regression guard)
   - Minimal query with no optional conditions
   - Sort order (ASC/DESC)
   - Optional conditions: serviceId, serviceInstanceId, endpointId
   - Related trace conditions: traceId, segmentId, spanId
   - Tag filtering with INNER JOIN (single and multiple tags)
   - limit + offset applied correctly
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to