sunnysabor commented on PR #7403: URL: https://github.com/apache/shenyu/pull/7403#issuecomment-5933914300
Heads-up: this overlaps with my #7402, opened from #7401 for the same `HeartbeatFailureIsolationTest` failure. Both fixes call `subscriber.start()` before draining the scheduled task; in #7402 the call is after the test populates its URI list, so the fixture is fully initialized before the subscriber is started. #7402 passes all 101 `shenyu-client-core` tests and its triggered CI. I agree the fix belongs in this test only. To avoid maintaining duplicate PRs, I am happy to close #7402 if the maintainers prefer this patch; otherwise we can keep whichever head they want to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
