lymerin opened a new pull request, #7380: URL: https://github.com/apache/shenyu/pull/7380
Fixes #7379. ### Summary - Move the `Install k8s` logic into a Bash script with `pipefail`, so a failed `curl` cannot be masked by `sh` reading empty input. - Retry up to three times unless both the installer succeeds and a nonempty kubeconfig exists. Keep the curl error visible, and fail with an explicit message after the third attempt. - Copy the kubeconfig into `~/.kube/config` with mode `600` instead of printing its contents to the CI log. - Run an offline shell test unconditionally in the workflow, including when a PR changes only `.github/**` files. ### Verification - On Ubuntu 24.04, `bash -n` and the offline shell test passed for download failure, missing kubeconfig, empty kubeconfig, and successful installation. The first three cases each attempted installation three times; success used one attempt. - Ran the installation script against an existing k3s `v1.29.6+k3s2` server. The installer reused the matching binary, copied the kubeconfig, and the node remained `Ready`. Restored the server kubeconfig permissions to `600` after verification. - Parsed the workflow YAML and ran `git diff --check`. - A full Maven build was not run because this PR changes only CI shell scripts and workflow configuration. ### CI scope For a PR that changes only `.github/**`, the workflow starts but its path filter skips the real `Install k8s` step. The new offline test still runs and exercises the same installation script. Please do not treat a skipped installation step as live cluster verification. ### Checklist - [x] I have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide). - [x] I submitted tests that cover the changed behavior. - [ ] My local test passed `./mvnw clean install -Dmaven.javadoc.skip=true` (not run; no Java changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
