(shenyu) branch master updated: fix: handle empty paramName in TimerAfterPredicateJudge to support default time-based conditions (#6942)

[liuhongyu]

This is an automated email from the ASF dual-hosted git repository.

Aias00 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git


The following commit(s) were added to refs/heads/master by this push:
     new dbade468bc fix: handle empty paramName in TimerAfterPredicateJudge to 
support default time-based conditions (#6942)
dbade468bc is described below

commit dbade468bc88b1fe50250ba916c78a21af1bee4e
Author: Limbo <yyk...@qq.com>
AuthorDate: Wed Sep 30 10:00:29 2026 +0800

    fix: handle empty paramName in TimerAfterPredicateJudge to support default 
time-based conditions (#6942)
    
    Co-authored-by: aias00 <liuhon...@apache.org>
---
 .../plugin/base/condition/judge/TimerAfterPredicateJudge.java     | 4 ++--
 .../plugin/base/condition/judge/PredicateJudgeFactoryTest.java    | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/condition/judge/TimerAfterPredicateJudge.java
 
b/shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/condition/judge/TimerAfterPredicateJudge.java
index 52ef2e179c..79009611cf 100644
--- 
a/shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/condition/judge/TimerAfterPredicateJudge.java
+++ 
b/shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/condition/judge/TimerAfterPredicateJudge.java
@@ -20,9 +20,9 @@ package org.apache.shenyu.plugin.base.condition.judge;
 import org.apache.shenyu.common.dto.ConditionData;
 import org.apache.shenyu.common.utils.DateUtils;
 import org.apache.shenyu.spi.Join;
+import org.springframework.util.StringUtils;
 
 import java.time.LocalDateTime;
-import java.util.Objects;
 
 /**
  * Timer after predicate judge.
@@ -33,7 +33,7 @@ public class TimerAfterPredicateJudge implements 
PredicateJudge {
     @Override
     public Boolean judge(final ConditionData conditionData, final String 
realData) {
         String paramName = conditionData.getParamName();
-        if (Objects.isNull(paramName)) {
+        if (!StringUtils.hasLength(paramName)) {
             return 
LocalDateTime.now().isAfter(DateUtils.parseLocalDateTime(conditionData.getParamValue().trim()));
         }
         return 
DateUtils.parseLocalDateTime(realData).isAfter(DateUtils.parseLocalDateTime(conditionData.getParamValue().trim()));
diff --git 
a/shenyu-plugin/shenyu-plugin-base/src/test/java/org/apache/shenyu/plugin/base/condition/judge/PredicateJudgeFactoryTest.java
 
b/shenyu-plugin/shenyu-plugin-base/src/test/java/org/apache/shenyu/plugin/base/condition/judge/PredicateJudgeFactoryTest.java
index 7ba17910c0..416c0036b3 100644
--- 
a/shenyu-plugin/shenyu-plugin-base/src/test/java/org/apache/shenyu/plugin/base/condition/judge/PredicateJudgeFactoryTest.java
+++ 
b/shenyu-plugin/shenyu-plugin-base/src/test/java/org/apache/shenyu/plugin/base/condition/judge/PredicateJudgeFactoryTest.java
@@ -118,6 +118,14 @@ public final class PredicateJudgeFactoryTest {
         assertFalse(PredicateJudgeFactory.judge(conditionData, FIRST_TIME));
     }
 
+    @Test
+    public void testTimerAfterJudgeWithEmptyParamName() {
+        conditionData.setOperator(OperatorEnum.TIME_AFTER.getAlias());
+        conditionData.setParamName("");
+        conditionData.setParamValue(FIRST_TIME);
+        assertTrue(PredicateJudgeFactory.judge(conditionData, "/http/"));
+    }
+
     @Test
     public void testExcludeJudge() {
         conditionData.setOperator(OperatorEnum.EXCLUDE.getAlias());