dengliming commented on code in PR #691:
URL: https://github.com/apache/shenyu-dashboard/pull/691#discussion_r4115047181
##########
src/models/common.js:
##########
@@ -48,8 +48,8 @@ export default {
effects: {
*fetchSelector({ payload }, { call, put }) {
- const { namespaceId } = payload;
- const json = yield call(getAllSelectors, { ...payload });
+ const { namespaceId, rulePageSize = 12, ...selectorPayload } = payload;
+ const json = yield call(getAllSelectors, { ...selectorPayload,
namespaceId });
Review Comment:
[P2] Format this call so the required lint step passes
Running `npm run lint` on this head fails at `src/models/common.js:52:49`
with `prettier/prettier`; `.github/workflows/build.yml` executes that same
command, so the PR will still fail CI after the functional pagination fix.
Please format the call as below and rerun lint:
```suggestion
const json = yield call(getAllSelectors, {
...selectorPayload,
namespaceId,
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
