Sean-Walker0 commented on PR #7318: URL: https://github.com/apache/shenyu/pull/7318#issuecomment-5847065965
Confirmed — deferring to #7317. I verified the merged patch independently: the registration-time `SESSION_NAMESPACE_IDS` capture closes exactly the dead-cleanup path diagnosed here (`getNamespaceId` returning `null` under `@OnClose`/`@OnError`, so the `#5734` removal never ran), the `onOpen` ordering fix matches ours, and the `compute`-based registration plus empty-set pruning is race-free as described. Nothing in this PR fixes a defect that #7317 leaves open. Closing in favor of #7317. One optional hardening note for the record — the fallback sweep @Aias00 asked to preserve is not in the merged version, so I left the concrete suggestion on #7317. Thanks for the thorough review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
