dengliming opened a new issue, #635: URL: https://github.com/apache/shenyu-dashboard/issues/635
## Description Copy-pasted `sorter` functions compare a different column than the one they are attached to, or subtract string ids. ## Location (Lines refer to `master @ 83969a5`.) - `src/routes/System/Instance/index.js:400,416,432` – `lastHeartBeatTime`, `dateCreated`, `instanceState` columns all sort by `instanceType` - `src/routes/System/Plugin/index.js:380` – `sort` column compares `role` - `src/routes/System/NamespacePlugin/index.js:302` – `sort` column compares `role` - `src/routes/System/PluginHandle/index.js:339` – `a.pluginId - b.pluginId` on string ids yields `NaN`, so sorting is a no-op ## Impact Clicking the sort arrows on these columns reorders rows by an unrelated field or not at all. ## Suggested fix Compare the column's own `dataIndex` and use `localeCompare`/numeric conversion where appropriate. ## Related existing None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
